Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double colons break benchmark names #62

Open
DaniPopes opened this issue Dec 20, 2024 · 1 comment
Open

Double colons break benchmark names #62

DaniPopes opened this issue Dec 20, 2024 · 1 comment
Assignees
Labels
Back bug Something isn't working

Comments

@art049 art049 added bug Something isn't working Back labels Dec 20, 2024 — with Linear
@art049 art049 self-assigned this Dec 20, 2024
Copy link
Member

art049 commented Dec 20, 2024

After looking, I realized this relates to having :: in your benchmark names. Currently we use this as a separator between the benchmark uri elements so we can identify in which mod/crate the call happened.

Since your benchmark name contains this separator, this messes with our internal parsing logic.

We are in the process of bringing more structure in the benchmark URIs so this problem doesn't happen anymore and we can also support having any kind of other chars that creates issues as of today, like \n

This is definitely annoying so we'll try to fix this asap.

Workaround

If you remove this "::" from your benchmark names, the problem wont happen anymore.

@art049 art049 changed the title Some benchmark names get cut off Double colons break benchmark names Dec 20, 2024
@adriencaccia adriencaccia assigned adriencaccia and unassigned art049 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants