Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create svg files for all images used in rc #149

Closed
2 tasks done
dpizetta opened this issue May 1, 2019 · 7 comments
Closed
2 tasks done

Create svg files for all images used in rc #149

dpizetta opened this issue May 1, 2019 · 7 comments
Assignees
Milestone

Comments

@dpizetta
Copy link
Collaborator

dpizetta commented May 1, 2019

As we started using scripts to process images from svg files to programmatically change colors, we need - also for quality images, svg files for all images. I'll provide it.

  • Provide svg for all resources used within a standard (KDE, Material);
  • Standardize resources names updating qsass, qrc, qss;
@dpizetta dpizetta added this to the 2.7 milestone May 1, 2019
@dpizetta dpizetta self-assigned this May 1, 2019
@goanpeca
Copy link
Collaborator

goanpeca commented May 4, 2019

Are we using some minimal HIC guide?

Something like https://hig.kde.org/style/icon.html ?

@dpizetta
Copy link
Collaborator Author

dpizetta commented May 4, 2019

Not until know, but we can use for sure.

I personally use this reference for my work: Material .

@goanpeca
Copy link
Collaborator

goanpeca commented May 4, 2019

Sure that one works ;-) although more oriented to web and mobile than "traditional" desktop

@dpizetta
Copy link
Collaborator Author

@goanpeca some questions, I've finished all svg files, however:

  • We keep all svg images in the same size, e.g, 32x32px? For example, vertical line is 32x6px.
  • The official size can be given in the style file in the case of proportion, e.g. 32x32px in the file, but using 12x12px for arrows for example. So we keep these files also with the same size?

The old rc files:
image

A big refactoring will be need to set all names. Using general_specific_action/state/etc, see below.
image

image

@goanpeca
Copy link
Collaborator

I would like to hace a fixed size if possible. Also depending on what the minimum size we aim for 24, 16, 32 ? We could make the images pixel perfect.

The standarized names is a welcome change :-)

@goanpeca
Copy link
Collaborator

Actually I think there is a reason for the dimensions of files that are not squared, so probably we need to keep those the same, with one side being 32 and the other whatever is needed to make the application look good.

The arrows are now looking weird on the file explorer (See the PR comment)

@dpizetta
Copy link
Collaborator Author

See PR #173 discussion. Closing this as they are added in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants