Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config connector does not allow to add taint on containerNodepool #3570

Open
3 tasks done
nnbu opened this issue Jan 30, 2025 · 1 comment
Open
3 tasks done

Config connector does not allow to add taint on containerNodepool #3570

nnbu opened this issue Jan 30, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@nnbu
Copy link

nnbu commented Jan 30, 2025

Checklist

Bug Description

Steps

  1. create containerNodepool on gke cluster. Allow config-connector to create the nodepool in gcp
  2. Add a taint to containerNodepool CR on GKE

This fails with error similar to

 message: 'Update call failed: cannot make changes to immutable field(s): [Field
      Name: nodeConfig.0.Taint.1.Effect, Got: NO_SCHEDULE, Wanted:  Field Name: nodeConfig.0.Taint.1.Value,
      Got: false, Wanted:  Field Name: nodeConfig.0.Taint.#, Got: 2, Wanted: 1 Field
      Name: nodeConfig.0.Taint.1.Key, Got: schedulepods1, Wanted: ]; please refer
      to our troubleshooting doc: https://cloud.google.com/config-connector/docs/troubleshooting'

Adding a taint to nodepool using gcloud command is allowed. So, this is not immutable field from gcp's pov. It looks to be the bug in config-connector.

Additional Diagnostic Information

While searching, I saw this comment. That suggests this to be a known limitation. But the comment is very old. I am not sure if there is a plan to address the issue about adding a taint to containerNodepool.

Kubernetes Cluster Version

1.30

Config Connector Version

1.121.0

Config Connector Mode

namespaced mode (default)

Log Output

No response

Steps to reproduce the issue

Mentioend above

YAML snippets

@nnbu nnbu added the bug Something isn't working label Jan 30, 2025
@nnbu
Copy link
Author

nnbu commented Jan 30, 2025

oh well.. this seems to have been fixed recently in 1.125
#2485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant