From 4a4f0ce369bcdb759f8f1dbb790242507a5ee197 Mon Sep 17 00:00:00 2001 From: Chris Jones Date: Thu, 14 Nov 2024 20:32:48 +0000 Subject: [PATCH] Fix a UI-off-main-thread bug --- Hammerspoon/MJPreferencesWindowController.m | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/Hammerspoon/MJPreferencesWindowController.m b/Hammerspoon/MJPreferencesWindowController.m index 88b928a20..ebf4bbf96 100644 --- a/Hammerspoon/MJPreferencesWindowController.m +++ b/Hammerspoon/MJPreferencesWindowController.m @@ -67,16 +67,17 @@ - (void) reflectDefaults { } - (void)updateFeedbackDisplay:(NSNotification __unused *)notification { - [self.openAtLoginCheckbox setState:MJAutoLaunchGet() ? NSControlStateValueOn : NSControlStateValueOff]; - [self.showDockIconCheckbox setState: MJDockIconVisible() ? NSControlStateValueOn : NSControlStateValueOff]; - [self.showMenuIconCheckbox setState: MJMenuIconVisible() ? NSControlStateValueOn : NSControlStateValueOff]; - [self.keepConsoleOnTopCheckbox setState: MJConsoleWindowAlwaysOnTop() ? NSControlStateValueOn : NSControlStateValueOff]; - [self.uploadCrashDataCheckbox setState: HSUploadCrashData() ? NSControlStateValueOn : NSControlStateValueOff]; + dispatch_async(dispatch_get_main_queue(), ^{ + [self.openAtLoginCheckbox setState:MJAutoLaunchGet() ? NSControlStateValueOn : NSControlStateValueOff]; + [self.showDockIconCheckbox setState: MJDockIconVisible() ? NSControlStateValueOn : NSControlStateValueOff]; + [self.showMenuIconCheckbox setState: MJMenuIconVisible() ? NSControlStateValueOn : NSControlStateValueOff]; + [self.keepConsoleOnTopCheckbox setState: MJConsoleWindowAlwaysOnTop() ? NSControlStateValueOn : NSControlStateValueOff]; + [self.uploadCrashDataCheckbox setState: HSUploadCrashData() ? NSControlStateValueOn : NSControlStateValueOff]; #ifndef SENTRY_API_URL - [self.uploadCrashDataCheckbox setState:NSControlStateValueOff]; - [self.uploadCrashDataCheckbox setEnabled:NO]; + [self.uploadCrashDataCheckbox setState:NSControlStateValueOff]; + [self.uploadCrashDataCheckbox setEnabled:NO]; #endif - + }); } - (void) showWindow:(id)sender {