Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Update lang_id readme file with list of languages that it supports #1005

Open
1 of 2 tasks
touma-I opened this issue Jan 31, 2025 · 4 comments
Open
1 of 2 tasks
Assignees
Labels
bug Something isn't working

Comments

@touma-I
Copy link
Collaborator

touma-I commented Jan 31, 2025

Search before asking

  • I searched the issues and found no similar issues.

Component

Documentation

What happened + What you expected to happen

Currently, it is not clear what languages lang_id can identify. One ask from Indian ecosystem is around the need for processing Indic languages like Hindi. Will be good to see if these models can support them out of the box

In the README file for this transform, we need to add some details about the languages that this transform is able to identify. The information we add needs to be very comprehensive to provide users with the detail needed.

While fixing the README, we will fix issue #1002.

Reproduction script

N/A

Anything else

No response

OS

Other

Python

Other

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@touma-I touma-I added the bug Something isn't working label Jan 31, 2025
@shahrokhDaijavad
Copy link
Member

@Ryan-Gordon-314159 For your attention.

@agoyal26
Copy link
Collaborator

agoyal26 commented Feb 6, 2025

In the current read-me, transform owner also needs to add their name and email address.

@shahrokhDaijavad shahrokhDaijavad assigned daw3rd and unassigned daw3rd Feb 6, 2025
@shahrokhDaijavad
Copy link
Member

In the current read-me, transform owner also needs to add their name and email address.

Will do, @agoyal26.
@Ryan-Gordon-314159 has agreed to make all the changes and will add @dtsuzuku-ibm's name.

@agoyal26
Copy link
Collaborator

agoyal26 commented Feb 6, 2025

Thanks @shahrokhDaijavad and @Ryan-Gordon-314159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants