fix(toDash): Fix default audio stream for dubbed movie trailers #858
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandfresh
approved these changes
Dec 31, 2024
LuanRT
approved these changes
Dec 31, 2024
absidue
added a commit
to absidue/YouTube.js
that referenced
this pull request
Feb 15, 2025
…ers (LuanRT#858)" This reverts commit 0054690.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Movie trailers usually only have the h264 and m4a streams. Dubbed movie trailers still only have that single itag 140 audio stream but have the
audio_trackproperty (withaudio_is_defaultset totrue) andxtags(withacont=dubbed) so when YouTube.js generates the DASH manifest for those trailers, it currently gives the audio stream thedubandalternateroles. This pull request fixes that so it gets thedubandmainroles (so correctly labelling it as the default audio stream).