Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several AssetsControllerTests broken #1010

Closed
legobeat opened this issue Dec 8, 2022 · 1 comment
Closed

Several AssetsControllerTests broken #1010

legobeat opened this issue Dec 8, 2022 · 1 comment

Comments

@legobeat
Copy link
Contributor

legobeat commented Dec 8, 2022

Some integration and unit tests fail when run locally on the package but ignored or silenced in CI.

Some of these are due to fetching from live endpoints which are deprecated (Infura returning errors for Ropsten testnet) or have differing behavior (Goerli tokens are now tracked at https://token-api.metaswap.codefi.network).

test.log

Related:
#413
#988
@desi
Copy link
Contributor

desi commented Apr 22, 2024

Believe this is fixed with #1499

@desi desi closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@desi @legobeat