Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether "cancel" transactions should be pushed to state in Transactions Controller as we do with "speed up" transactions #1168

Open
adonesky1 opened this issue Apr 5, 2023 · 1 comment

Comments

@adonesky1
Copy link
Contributor

Is there some reason we don't add "cancel" transactions into the transactions array like we do with speedup transactions?
cancel:

this.hub.emit(`${transactionMeta.id}:finished`, transactionMeta);

speedup:
transactions.push(newTransactionMeta);

@ptdatta
Copy link

ptdatta commented Apr 16, 2023

Hey @adonesky1 , Can I work on it??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants