Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linking libraries for local development #1586

Closed
Gudahtt opened this issue Aug 15, 2023 · 0 comments · Fixed by #1623
Closed

Support linking libraries for local development #1586

Gudahtt opened this issue Aug 15, 2023 · 0 comments · Fixed by #1623
Assignees
Labels

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Aug 15, 2023

We should allow linking libraries during local development to allow for quick feedback loops when testing library changes in mobile or extension.

Today this doesn't work because we use the workspace: protocol for inter-package dependencies, which isn't resolved until the package is published. Contributors are forced to use preview builds just to get builds to test with locally, or they have to build locally and awkwardly copy over the build files. Preview builds are great for testing changes in the client repositories in CI, but we shouldn't need to use them for local development.

@Gudahtt Gudahtt added the enhancement New feature or request label Aug 15, 2023
@mcmire mcmire self-assigned this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants