Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NftController: Refactor #1606

Open
mcmire opened this issue Aug 18, 2023 · 0 comments
Open

NftController: Refactor #1606

mcmire opened this issue Aug 18, 2023 · 0 comments
Labels
team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Aug 18, 2023 •
edited
Loading

NftController makes several API calls to request information about NFTs. Most of the code is contain in private methods. Additionally, there is a lot of code around normalizing returned API data which increases the complexity. This code should be extracted to separate files and then refactored appropriately. This should make that code easier to test as well.
@mcmire mcmire changed the title NftController: Refactor so that it easier to understand and test NftController: Refactor API interactions Aug 18, 2023
@mcmire mcmire changed the title NftController: Refactor API interactions NftController: Refactor Aug 18, 2023
@mcmire mcmire mentioned this issue Aug 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcmire @desi