Fix findNetworkClientIdByChainId to consider default endpoints #5344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `findNetworkClientIdByChainId` method in `NetworkController`, which is used in various places, mostly commonly TransactionController and the wallet middleware, returns the network client ID corresponding to the first listed RPC endpoint for the given chain. This may not match users' expectations if they have chosen another RPC endpoint as the default. This commit fixes the implementation of `findNetworkClientIdByChainId` to match this expectation.
mcmire
force-pushed
the
fix-find-network-client-id-by-chain-id
branch
from
de00c01 to
8370668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, the
findNetworkClientIdByChainIdmethod inNetworkController, which is used in various places, mostly commonly TransactionController and the wallet middleware, returns the network client ID corresponding to the first listed RPC endpoint for the given chain. This may not match users' expectations if they have chosen another RPC endpoint as the default. This commit fixes the implementation offindNetworkClientIdByChainIdto match this expectation.References
Fixes #3686.
Changelog
(Updated in changelog.)
Checklist