Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview build publishing workflow in a topic PR may fail if release PR has been merged to main but new version has not been published yet #5308

Open
mcmire opened this issue Feb 11, 2025 · 1 comment
Labels
bug Something isn't working team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Feb 11, 2025

If you merge a release PR that bumps the version of a package that has dependents such as @metamask/base-controller, but you do not approve the release yet (i.e., the new version is not published), then when you open a PR and attempt to publish preview builds, the workflow will fail during the step that changes all of the workspace package names to their preview equivalent. Because of this, Yarn attempts to resolve dependencies to their published version instead of their local version, and when it does this, it isn't able to find the published version.

To fix this, we could consider overwriting all interdependencies to use the preview build versions by renaming them from @metamask/ to @metamask-previews/ and adjusting their versions.

@mcmire mcmire added bug Something isn't working team-wallet-framework labels Feb 11, 2025
@mcmire
Copy link
Contributor Author

mcmire commented Feb 14, 2025

When we switched the monorepo over from using workspace: references, we thought about doing this and decided against it because we thought that it would cause pain for client developers, as it would break transitive dependencies for existing controllers: #4461 (comment)

Considering that this issue originally popped up for base-controller, however, perhaps we could make an exception for this or any other non-instantiatable controllers such as polling-controller?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team-wallet-framework
Projects
None yet
Development

No branches or pull requests

1 participant