Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add justification field #719

Open
danfinlay opened this issue Feb 4, 2019 · 1 comment
Open

Add justification field #719

danfinlay opened this issue Feb 4, 2019 · 1 comment
Labels
PermissionController Related to the PermissionController. team-wallet-api-platform team-wallet-framework

Comments

@danfinlay
Copy link
Contributor

A requested permission should permit an optional justification field that is passed to the user confirmation function, to enhance the context of the prompt.

Should support text, but also be forward-extensible to other justification formats.
@rekmarks rekmarks transferred this issue from MetaMask/rpc-cap Jan 3, 2022
@rekmarks rekmarks added the PermissionController Related to the PermissionController. label Jan 3, 2022
@rekmarks rekmarks transferred this issue from MetaMask/snaps Mar 11, 2022
@rekmarks rekmarks added the enhancement New feature or request label Apr 26, 2024
@rekmarks
Copy link
Member

This feature would be problematic from a localization perspective, but is perhaps something we could consider if we ever have programmatic (i.e. LLM-based) translations in the wallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PermissionController Related to the PermissionController. team-wallet-api-platform team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@desi @danfinlay @rekmarks