New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't stub prototypes #750

Open

mcmire opened this issue Mar 23, 2022 · 0 comments

Labels

team-wallet-framework

Contributor

mcmire commented Mar 23, 2022 •

edited

Loading

Stubbing the prototype of the class under test is effectively the same as testing private functions, which is covered by Don't test private functions #749.
Stubbing the prototype of a library that isn't under test should be unnecessary. Anything we need to stub in a controller should be passed in as a parameter to the constructor.

mcmire mentioned this issue

Improve unit tests #413

Open

49 tasks

desi added the team-wallet-framework label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment