Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyringController:signPersonalMessage does not fail if empty data is passed. #799

Open
jpuri opened this issue Apr 25, 2022 · 1 comment
Open

KeyringController:signPersonalMessage does not fail if empty data is passed. #799

jpuri opened this issue Apr 25, 2022 · 1 comment
Assignees
@mikesposito
Labels
team-wallet-framework

Comments

@jpuri
Copy link
Contributor

jpuri commented Apr 25, 2022

KeyringController:signMessage fails if empty data is passed but KeyringController:signPersonalMessage does not fails if empty data is passed.
@jpuri jpuri mentioned this issue Apr 25, 2022
Merged
@Gudahtt
Copy link
Member

Gudahtt commented Apr 25, 2022

Does the spec require that the data be non-empty? Worth confirming that - maybe this is fine.

Also we should check to see if it's possible that a dapp is relying upon this. We might be forced to preserve this behavior for backwards-compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikesposito mikesposito

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@desi @jpuri @Gudahtt @mikesposito