Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose KeyringControler.verifyPassword #870

Open
owencraston opened this issue Jul 8, 2022 · 2 comments
Open

expose KeyringControler.verifyPassword #870

owencraston opened this issue Jul 8, 2022 · 2 comments
Labels
team-wallet-framework

Comments

@owencraston
Copy link
Contributor

Currently we are validating passwords by calling await KeyringController.submitPassword(credentials.password) which is a heavy operation and is dramatically slowing down the UI. I see that base KeyringController has a verifyPassword method that is not exposed by this wrapper. We could expose this method so we can check passwords without running a full update.
@desi
Copy link
Contributor

desi commented May 1, 2024

We do now expose verifyPassword but not in the recommended way. We should also update on mobile.

@desi
Copy link
Contributor

desi commented May 1, 2024

Potential blocker for Wallet Frame - Desi add to release (once I create).

Remaining work is to add action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@desi @owencraston