Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate snap update permission operations in PermissionController #871

Open
rekmarks opened this issue Jul 11, 2022 · 1 comment
Open

Encapsulate snap update permission operations in PermissionController #871

rekmarks opened this issue Jul 11, 2022 · 1 comment
Assignees
@rekmarks
Labels
PermissionController Related to the PermissionController. team-wallet-api-platform team-wallet-framework

Comments

@rekmarks
Copy link
Member

The SnapController.updateSnap() method performs some permission calculations that should occur in the PermissionController. In particular, it compares the permissions of an existing snap with that of a new version, revokes ones that no longer exist, and grants ones that were added. It accomplishes this by calling PermissionController actions. Ideally, these operations would be encapsulated within the PermissionController, while the approval request is managed by the SnapController.
@rekmarks rekmarks added the PermissionController Related to the PermissionController. label Jul 11, 2022
@hmalik88 hmalik88 self-assigned this Jul 13, 2022
@Montoya Montoya changed the title Encapsulate snap update permission operations in PermissionController Encapsulate snap update permission operations in PermissionController (Q4) Sep 12, 2022
@rekmarks rekmarks changed the title Encapsulate snap update permission operations in PermissionController (Q4) Encapsulate snap update permission operations in PermissionController Nov 9, 2022
@rekmarks
Copy link
Member Author

This is likely to be fixed by #4163 and related work.

@rekmarks rekmarks self-assigned this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rekmarks rekmarks

Labels
PermissionController Related to the PermissionController. team-wallet-api-platform team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@desi @rekmarks @hmalik88