New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenListController tests are brittle #917

Open

BelfordZ opened this issue Sep 22, 2022 · 0 comments

Labels

team-wallet-framework

Contributor

BelfordZ commented Sep 22, 2022

there is a lot of setTimeouts used with magic numbers to wait for things that should be handled using promises.

For example, this test fails particularly often:
https://github.com/MetaMask/controllers/blob/main/src/assets/TokenListController.test.ts#L602

desi added the team-wallet-framework label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment