Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PhishingController error handling #923

Open
Gudahtt opened this issue Sep 28, 2022 · 1 comment
Open

Improve PhishingController error handling #923

Gudahtt opened this issue Sep 28, 2022 · 1 comment
Labels
enhancement New feature or request team-product-safety Push issues to Product Safety team team-wallet-framework

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Sep 28, 2022

The PhishingController error handling for config updates has room for improvement. Currently config update failures are swallowed, so there is no opportunity for caller to discover this or retry. Some types of failure are not even logged.

We should ensure that config update failures are not suppressed with updatePhishingLists is called, so that the caller is aware when a failure has occurred. In any circumstance where it is necessary to suppress config update failures (e.g. in test), we should at least ensure the failure is logged, for debugging purposes.

@desi
Copy link
Contributor

desi commented Apr 22, 2024

Should revisit the description and how to implement.

@MajorLift MajorLift added the team-product-safety Push issues to Product Safety team label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request team-product-safety Push issues to Product Safety team team-wallet-framework
Projects
None yet
Development

No branches or pull requests

3 participants