Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve network controller test coverage #972

Closed
Gudahtt opened this issue Nov 17, 2022 · 1 comment · Fixed by #1039
Closed

Improve network controller test coverage #972

Gudahtt opened this issue Nov 17, 2022 · 1 comment · Fixed by #1039
Assignees
@mcmire
Labels
enhancement New feature or request team-wallet-api-platform

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Nov 17, 2022 •
edited
Loading

We should ensure the network controllers is thoroughly unit tested. We should ensure the unit tests follow the best practices outlined here: #413
@Gudahtt Gudahtt added the enhancement New feature or request label Nov 17, 2022
@Gudahtt
Copy link
Member Author

Gudahtt commented Dec 8, 2022

Revisit this when the planning for #971 has been completed.
If we can get a solid idea of what parts of the current network controller are staying and which are changing, that would be helpful in planning out these tests.

@Gudahtt Gudahtt self-assigned this Dec 8, 2022
@Gudahtt Gudahtt mentioned this issue Dec 14, 2022
Merged
8 tasks
@mcmire mcmire assigned mcmire and unassigned Gudahtt Dec 20, 2022
@mcmire mcmire mentioned this issue Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcmire mcmire

Labels
enhancement New feature or request team-wallet-api-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite NetworkController unit tests MetaMask/core
3 participants
@mcmire @kenhkan @Gudahtt