Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the purpose and history of the controller pattern #992

Open
mcmire opened this issue Nov 29, 2022 · 2 comments
Open

Document the purpose and history of the controller pattern #992

mcmire opened this issue Nov 29, 2022 · 2 comments
Labels
team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Nov 29, 2022 •
edited
Loading

If you're new to the monorepo, you might want to know: just what is a controller? Why do we have two versions of the controller pattern, and what problems did the second version solve?
@mcmire mcmire mentioned this issue Nov 29, 2022
Closed
@mcmire mcmire self-assigned this Nov 29, 2022
@mcmire
Copy link
Contributor Author

mcmire commented Aug 2, 2023 •
edited
Loading

As we already have some documentation for the core monorepo, I have updated the PR description to list only items that we have not yet completed. We may wish to split this ticket up into multiple tickets, but for now I'll leave this here.

@mcmire mcmire changed the title Add documentation Add more documentation Aug 2, 2023
@mcmire mcmire changed the title Add more documentation Document the "controller" concept Aug 16, 2023
@mcmire mcmire changed the title Document the "controller" concept Document the purpose and history of the controller pattern Aug 16, 2023
@mcmire
Copy link
Contributor Author

mcmire commented Aug 16, 2023

I've split the architecture documentation into its own ticket (#1588) and renamed this ticket.

@mcmire mcmire removed their assignment Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add documentation MetaMask/core
2 participants
@mcmire @desi