Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Rename Trezor's dispose method to destroy #178

Closed
mikesposito opened this issue Jun 15, 2023 · 0 comments · Fixed by #179
Closed

Rename Trezor's dispose method to destroy #178

mikesposito opened this issue Jun 15, 2023 · 0 comments · Fixed by #179
Labels
team-wallet-framework

Comments

@mikesposito
Copy link
Member

Currently, the type we use for Keyrings does not include a "destroy" function. On the other hand, Ledger and Trezor keyring have a function for this and is named dispose for Trezor and destroy for Ledger.

We should align the two hardware keyrings, renaming Trezor's dispose to destroy
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename dispose to destroy MetaMask/eth-trezor-keyring
1 participant
@mikesposito