Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace secp256k1 & keccak with @noble/secp256k1 & @noble/hashes throughout dependency tree #15904

Open
adonesky1 opened this issue Sep 20, 2022 · 1 comment
Open

Replace secp256k1 & keccak with @noble/secp256k1 & @noble/hashes throughout dependency tree #15904

adonesky1 opened this issue Sep 20, 2022 · 1 comment
Labels
epic MV3 team-extension-platform Extension Platform team

Comments

@adonesky1
Copy link
Contributor

adonesky1 commented Sep 20, 2022 •
edited
Loading

This is a sprawling effort since secp256k1 and keccak are found throughout our dependency tree embedded in our package and our external dependencies. This epic should include all subtickets that are required to fully replace these heavy crypto implementations with their noble counterparts in our dependency graph.

Old ticket
@adonesky1 adonesky1 added the MV3 label Sep 20, 2022
@adonesky1 adonesky1 self-assigned this Sep 20, 2022
@adonesky1 adonesky1 added the epic label Sep 20, 2022
@hilvmason hilvmason added the team-extension-platform Extension Platform team label Jan 17, 2023
@adonesky1 adonesky1 removed their assignment Jan 17, 2023
@adonesky1 adonesky1 changed the title Replace heavy crypto packages with Noble Implementations Replace heavy crypto packages (secp256k1 & keccak) with noble Implementations Jan 17, 2023
@adonesky1 adonesky1 changed the title Replace heavy crypto packages (secp256k1 & keccak) with noble Implementations Replace heavy crypto packages (secp256k1 & keccak) with noble Implementations (@noble/secp256k1 & @noble/hashes) Jan 17, 2023
@adonesky1 adonesky1 changed the title Replace heavy crypto packages (secp256k1 & keccak) with noble Implementations (@noble/secp256k1 & @noble/hashes) Replace secp256k1 & keccak)with @noble/secp256k1 & @noble/hashes throughout dependency tree Jan 17, 2023
@adonesky1 adonesky1 changed the title Replace secp256k1 & keccak)with @noble/secp256k1 & @noble/hashes throughout dependency tree Replace secp256k1 & keccak with @noble/secp256k1 & @noble/hashes throughout dependency tree Jan 17, 2023
@adonesky1 adonesky1 mentioned this issue Jan 17, 2023
Open
@mcmire mcmire mentioned this issue Apr 25, 2024
Open
@paulmillr
Copy link

This can be closed, Metamask has long switched to noble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic MV3 team-extension-platform Extension Platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paulmillr @gauthierpetetin @adonesky1 @hilvmason