Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

Request-Id header is injected twice with latest DiagnosticSource package from myget #530

Closed
lmolkova opened this issue May 1, 2017 · 1 comment

Comments

@lmolkova
Copy link
Member

lmolkova commented May 1, 2017

When HttpDesktopDiagnosticSourceListener receives System.Net.Http.Desktop.HttpRequestOut.Start event from DiagnosticSource, it injects Request-Id header.

After that DiagnosticSource injects it too.

AppInsights must only inject the header if request is instrumented with profiler .

This issue does not break customers since they use version of DiagnosticSource that do not inject headers (the only one available on nuget.org).

However the fix is needed in the stable release with updated DiagnosticSource.

cijothomas added a commit that referenced this issue May 5, 2017
…ion.1

Prevent double header injection with Http Desktop DiagnosticSource (#530)
@lmolkova
Copy link
Member Author

fixed with #543

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant