Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support collecting non-HTTP dependency calls from 3rd party libraries #1595

Closed
TomMilos opened this issue Aug 17, 2017 · 10 comments
Closed

Support collecting non-HTTP dependency calls from 3rd party libraries #1595

TomMilos opened this issue Aug 17, 2017 · 10 comments
Assignees

Comments

@TomMilos
Copy link

Use DiagnosticSource to collect RDD telemetry from 3rd-party SDKs/libraries. This requires defining the "contract" for dependency collection which later can be implemented directly in particular libraries

The approach we want to use is based on DiagnosticSource Activities - AI DependencyTrackingTelemetryModule will implement a DiagnosticSource subscriber which will subscribe to all activities following given naming convention (TBD) with possible support of config-based white/blacklists. All of those activities are expected to follow the OpenTracing tag naming convention (https://github.com/opentracing/specification/blob/master/semantic_conventions.md) which will allow the listener to construct meaningful RDD telemetry.

The next steps are to contribute to selected 3rd-party projects in order to add corresponding Activities relevant to given technology

@billpratt
Copy link

I would like to help with this as I've been reviewing how to do it with MongoDB

TomMilos referenced this issue in TomMilos/ApplicationInsights-dotnet-server Oct 13, 2017
@TimothyMothra
Copy link
Member

@TomMilos Can we close this and create separate items for 3rd party?

@TimothyMothra
Copy link
Member

@TomMilos please update

@andymac4182
Copy link

Is there any update on this? I saw Redis showing up as a dependency at Build. It would be great if this was coming soon.

@lmolkova
Copy link
Member

@andymac4182 could you please point me to the slides/video with Redis dependency? This is something we discussing with Redis StackExchange team now, but have not got any agreement yet.

@andymac4182
Copy link

@lmolkova https://youtu.be/vPZiwi-15_U?list=PLlrxD0HtieHg7uB3_amVXvaRgxIcXLtYD&t=2558 Here is the video that I was referring to.

@qrli
Copy link

qrli commented Aug 23, 2019

Any progress? I'm interested in Mongo dependency calls.

@TimothyMothra TimothyMothra transferred this issue from microsoft/ApplicationInsights-dotnet-server Jan 10, 2020
@milkshakeuk
Copy link

milkshakeuk commented Jun 16, 2020

@cijothomas
Copy link
Contributor

@milkshakeuk There are no additional dependency collection planned for application insights SDK this year. We are investing into OpenTelemetry and any new dependency collection will come through open telemetry integration - The details about the same would be shared in the coming months. (most likely all that users need to do is to simply upgrade to newer version of SDK, and underneath it could use OpenTelemetry.. but these details are not yet designed and hence not shared)

@github-actions
Copy link

This issue is stale because it has been open 300 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants