Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Decompiler --> Listing window scrolling #7518

Open
leechristensen opened this issue Feb 17, 2025 · 0 comments
Open

Improve Decompiler --> Listing window scrolling #7518

leechristensen opened this issue Feb 17, 2025 · 0 comments

Comments

@leechristensen
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Setup: I have the Decompiler window and the Listing window side-by-side viewing a decompiled function. In the Decompiler window, I click the function's name (at the very top of the Decompiler window) or one its local variable definitions.

Observed Behavior:

  • When I click on the function name or local variable definition in the Decompiler window, Ghidra scrolls the Listing window to the first assembly instruction in the function and NOT to the function definition or local variable. In this example, note that I clicked on the woot variable and it's not immediately displayed in front of me in the Listing window (I have to scroll up):

Image

  • I can scroll up, but when there's a lot of local variables, it can be difficult to find the exact one I'm looking for because it's not highlighted nor put directly in front of me (especially happens when your eyes are bleeding after looking at a lot of code). For example, :

Image

Describe the solution you'd like
My expected behavior:

  • If I click on the function's name in the Decompiler window, the Listing window scrolls to the function and puts it in front of my eyes (note that the function is highlighted in the Listing window):

Image

  • If i click on a local variable in the Decompiler window, the Listing window scrolls to the variable in the Listing window (note that the variable woot is highlighted in the Listing window):

Image

Describe alternatives you've considered
None.

Additional context
When troubleshooting poor/unreadable decompilations, I compare how argument/local variable types are defined in the Decompiler against what's defined the in Listing window to determine what other variables haven't been manually assigned a type yet (e.g., if the decompiler is inferring/propagating types incorrectly). When there's lots of local variables or I want to see how function arguments are typed in the Listing window, it becomes cumbersome to have to scroll and manually locate the variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant