Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Change array list attribute to integer attribute #1497

Open
erick-xanadu opened this issue Feb 5, 2025 · 0 comments
Open

[chore] Change array list attribute to integer attribute #1497

erick-xanadu opened this issue Feb 5, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@erick-xanadu
Copy link
Contributor

custom_calls will have the following syntax:

%0 = catalyst.custom_call fn("lapack_dgesdd") (%arg0, %arg1) {number_original_arg = array<i32: 1>} : (memref<3x3xf64>, memref<3x3xf64>) -> memref<3x3xf64>

This number_original_arg has no reason to be an integer array. It can be just an integer.

(env) ubuntu@touched-stingray:~/code/catalyst$ git grep getNumberOriginal
mlir/lib/Catalyst/Transforms/catalyst_to_llvm.cpp:        int32_t numberArg = op.getNumberOriginalArgAttr()[0];
@erick-xanadu erick-xanadu added the good first issue Good for newcomers label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant