Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD string truncated #333

Closed
gingerbeardman opened this issue Apr 5, 2017 · 3 comments
Closed

OSD string truncated #333

gingerbeardman opened this issue Apr 5, 2017 · 3 comments

Comments

@gingerbeardman
Copy link

gingerbeardman commented Apr 5, 2017

using 2.1.1 for Mac OS X

device #4: Playback 1
address:       1.1.0.0
active source: yes
vendor:        Unknown
osd string:    NintendoSwitc
CEC version:   1.3a
power status:  on
language:      ???

on my TV via CEC it shows as NintendoSwitch, with the final character h

also:

TRAFFIC: [            8183]	>> 4f:87:00:09:bf
DEBUG:   [            8183]	>> Playback 1 (4) -> Broadcast (F): device vendor id (87)
DEBUG:   [            8183]	Playback 1 (4): vendor = Unknown (0009bf)

0009bf is Nintendo

@gingerbeardman gingerbeardman changed the title odd string truncated OSD string truncated Apr 5, 2017
@pfiaux
Copy link

pfiaux commented Jun 28, 2017

It might be a limitation on the OSD string length in libcec. If the OSD string is handled the same way as strDeviceName in libcec_configuration it looks like it's limited to a length of 13 characters.

For example in cecetypes.h:
typedef char cec_osd_name[14]; /**< the name of the device */
(I'm not sure but my guess is 13 + null termination)

@opdenkamp
Copy link
Contributor

Just checked, it looks like this is a bug that has been corrected incorrectly last time... Maximum length is 14 bytes according to spec, not 13. Because other apps depend on the NULL terminator most likely, I can't change this without bumping the major version number.

@opdenkamp
Copy link
Contributor

this will be fixed after the version bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants