-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is no way to add borders to a drawer component #6803
Comments
I would suggest that the |
@ljemmo and @harpalsingh thoughts on updating the designs for Drawer to support the above? |
@elvis-iacobescu-sage please can you share a design via slack or teams for us to understand what this change would mean visually? |
@ljemmo @elvis-iacobescu-sage Hey both. Just chasing to see if you got anywhere further with this and if designs had been shared so a decision could be made? Thanks! |
@ljemmo any updates? |
@edleeks87 I believe @ljemmo was still waiting for a response from @elvis-iacobescu-sage regarding the designs so that a decision could be made. Elvis, would it be possible to pick this up with Luke when you get a moment? Thank you! |
This was the expected design from UX And this is how it looks with no top border |
ok thanks @spookendiesel - the request seems fair enough. @nineteen88 or @edleeks87 from a DS perspective happy to support this. In the newest DS version we offer standard and subtle border colors so i suggest we offer the same props here. Thoughts appreciated. |
@spookendiesel Do you know which designer provided that version of breadcrumbs and/or was this a requirement because the following design of breadcrumbs wasnt possible? (Screenshot 3 removed and added to ticket) @ljemmo We might want to consider if this is a border on the top of the Drawer or its a border at the bottom of a container with the breadcrumbs first. |
@harpalsingh I think it was Dale Pealing. The original discussion can be found here (Link removed and added to ticket) |
FE-6872 |
Do we need to support only the border variants, i.e. default would be the existing right/left border depending on orientation. Setting subtle will set the colour of the current default border as well as top and bottom? etc. Or should we offer more granular control in terms of setting top, left, right and bottom borders independently? |
IMo i can't see a usecase for granular border control. Setting borders based on the orientation makes sense to me. |
Description
I have 2 components Breadcrumbs and a drawer component. The drawer has a 1px border top In the designs. Right now I have to do a workaround to be able to add a top border(
<Hr my={0} >
). We need a way to add borders to the box component or the drawer component designs.Suggested solution
Add a border to the box Component or the Drawer component, or create a specific component that would be able to add borders around existing components
Demo URL
No response
Alternatives
No response
Additional context
No response
Confidentiality
The text was updated successfully, but these errors were encountered: