sea-orm-cli generate entity --tables argument doesn't work as described

[johnbcodes]

Description

sea-orm-cli generate entity --tables says that it takes a comma-separated list of tables to generate entities for.

    -t, --tables <TABLES>
            Generate entity file for specified tables only (comma separated)

However, the Clap definition uses Option<String> instead of Vec<String>. All tables after the first comma are ignored.

If the intent is to support multiple tables, the change is small and doesn't harm the single table use case. If the intent is to only generate a single entity, then I think the help should be updated. Either way I'm willing to do the work once I know.

Steps to Reproduce

1. Create a database with ledger_entries and checks tables
2. Execute sea-orm-cli generate entity -u <DATABASE_URL> --tables ledger_entries,checks -o src/entities

Expected Behavior

Generates entities for the ledger_entries and checks tables

Actual Behavior

Only generates entity for ledger_entries

Reproduces How Often

Always

Versions

0.10.3
SQLite
Mac OS 12.6

[tyt2y3]

It should be able to support multiple tables AFAIK @billy1624

[billy1624]

Hey @johnbcodes, thanks for the report!! I'm not sure why it was originally be implemented this way. The original approach takes a comma separated table name and then conditionally generate entity of those with table name is a substring of the comma separated input.

That means, if you have tables user, user_group and group in your database. Then, given your comma separated input be user. It will generate the entity file for user and user_group tables.

Which isn't what we want!

[billy1624]

I just fix the issue on #1245

[johnbcodes]

Thank you @billy1624 @tyt2y3!