Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not rename src/test to src/mocks? #948

Closed
smol-ninja opened this issue Feb 13, 2025 · 3 comments · May be fixed by #949
Closed

Why not rename src/test to src/mocks? #948

smol-ninja opened this issue Feb 13, 2025 · 3 comments · May be fixed by #949

Comments

@smol-ninja
Copy link

Most of the files inside src/test represent mock contracts. Would it not be a good idea to rename it to src/mocks as src/test is expected to have test code?

And if its indeed test code, why not put it in test/ directory?
@linear Linear
Copy link

linear bot commented Feb 13, 2025

PROTO-747 Why not rename `src/test` to `src/mocks`?

@mohitsaini0660
Copy link

i can can do it

@mohitsaini0660 mohitsaini0660 mentioned this issue Feb 16, 2025
Open
@smol-ninja
Copy link
Author

nvm. Its clearly mentioned in their readme that this folder is for helper contracts used by tests

@smol-ninja smol-ninja closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changes src/test/ with src/mocks/ mohitsaini0660/Uniswap
2 participants
@smol-ninja @mohitsaini0660