Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: More elegant display of error messages in terminal #913

Closed
3 tasks done
majin1102 opened this issue Dec 9, 2022 · 2 comments
Closed
3 tasks done

[Improvement]: More elegant display of error messages in terminal #913

majin1102 opened this issue Dec 9, 2022 · 2 comments
Labels
module:ams-server Ams server module type:improvement
Milestone
Release 0.4.1

Comments

@majin1102
Copy link
Contributor

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

So far terminal log shows error message as below:

image

There could be three points to improve:

  1. show red Error status instead of green Finished status
  2. use red color for error message and error stacks
  3. display /t for stack rows

How should we improve?

  1. return Error status when throwing error instead of Finished
  2. split error logs and processing logs into different return packages
  3. UI display red for Error status and error logs.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct
@majin1102 majin1102 added this to the Release 0.4.1 milestone Dec 9, 2022
@majin1102
Copy link
Contributor Author

cc @huiyuanz

@zhoujinsong
Copy link
Contributor

Resolved by #1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:ams-server Ams server module type:improvement
Projects
None yet
Milestone
Release 0.4.1
Development

No branches or pull requests
2 participants
@majin1102 @zhoujinsong