Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$gel-type-touch-class confusing name #46

Open
howieweiner opened this issue May 19, 2016 · 5 comments
Open

$gel-type-touch-class confusing name #46

howieweiner opened this issue May 19, 2016 · 5 comments
Labels

Comments

@howieweiner
Copy link

$gel-type-touch-class requires the class name of the NO touch class. Somewhat confusing

@shaunbent
Copy link
Contributor

Would you prefer $gel-type-no-touch-class or $gel-type-no-touch-class-name?!?

I guess because I know what it does I never thought it might be a bit confusing.

@howieweiner
Copy link
Author

$gel-type-no-touch-class is fine, but don't want this to become a breaking change.. unless you extend your logic to look for one or the other variable name?

@shaunbent
Copy link
Contributor

Yeah I was thinking of allowing both variables and deprecating the existing one and throwing a warning if its used to suggest people upgrade to the new one.

@howieweiner
Copy link
Author

👍 for the warning

@itsaljones
Copy link
Contributor

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants