Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font stack is inconsistent with Barlesque #47

Open
howieweiner opened this issue May 20, 2016 · 2 comments
Open

Font stack is inconsistent with Barlesque #47

howieweiner opened this issue May 20, 2016 · 2 comments
Assignees
Labels

Comments

@howieweiner
Copy link

If $gel-type-enable--font-family is enabled, the font stack produced by gel-typography is inconsistent with that in Barlesque/Orb

Compare:
https://github.com/bbc/gel-typography/blob/master/_typography.scss#L41

With:
https://github.com/bbc/nav-orbit/blob/master/static-sources/sass/global/_reset.scss#L251
and
https://github.com/bbc/nav-barlesque/blob/a44453ec49a5edb99390b523f4a354a500757103/static-sources/orb/sass/global/_reset.scss#L251

As most teams will not need to enable the font-family flag, the demo pages for this project are misleading, as they appear to have been built with this flag enabled

@shaunbent
Copy link
Contributor

@itsaljones can you add some thoughts to this?!?

@itsaljones
Copy link
Contributor

Yeah it would be good to make them consistent and in-line with the Guidelines so: Helvetica, Ariel, sans-serif.

I propose we tweak all of the above links to match. Thoughts? @howieweiner @shaunbent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants