Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to empty fields when data is unavailable from source #1173

Open
l-t-k opened this issue Dec 28, 2014 · 6 comments
Open

Option to empty fields when data is unavailable from source #1173

l-t-k opened this issue Dec 28, 2014 · 6 comments
Labels
feature features we would like to implement

Comments

@l-t-k
Copy link
Contributor

l-t-k commented Dec 28, 2014

Is it possible to scrub or remove tags from files that should be empty following the musicbrainz database, but comes with some value prior to tagging?

For example, I tagged some files which contained a (wrong) composer, but the composer field in the MB database was empty. Therefore, the tagger didn't removed the composer-tag from the files. In my view, the tagger should remove the composer-tag from the file by default if it is empty in the MB-database

@sampsyo
Copy link
Member

sampsyo commented Dec 28, 2014

Thanks for the feedback. What you're seeing here is just because we don't currently fetch the composer from MB at all (#506). You can use zero to clear it out if you like.

@sampsyo sampsyo closed this as completed Dec 28, 2014
@l-t-k
Copy link
Contributor Author

l-t-k commented Dec 28, 2014

I have some albums which contain a label-tag in the file. However, MB says these albums have no labels at all. In that case, beets is not removing the label-tag from the files.

I think this should be an option somewhere. For example, Musicbrainz Picard has an option to remove tags before writing the new ones. Such an option, for example within the scrub-plugin, should solve this problem.

@sampsyo sampsyo changed the title Scrubbing/removing tags from files with empty musicbrainz fields? Option to empty fields when data is unavailable from source Dec 28, 2014
@sampsyo
Copy link
Member

sampsyo commented Dec 28, 2014

OK, that makes sense. Thanks for explaining further.

An option like this makes sense—although I'm not sure whether it would go in the scrub plugin. The logic there is quite specialized to remove tags that are otherwise "invisible" to beets, even if the effect is intuitively similar.

@l-t-k
Copy link
Contributor Author

l-t-k commented Jan 25, 2015

#934 Basically the same

@Freso
Copy link
Member

Freso commented Jan 25, 2015

Not quite the same as I read the two issues. 934 is about tagging the file from a completely blank slate, ie., removing all data from the file before writing new data to. I read this issue more like "file has cat. no. data but MusicBrainz doesn't, so clear local data". Using composers as example: with 934 composers would (currently) always be wiped, but with this, they would not be touched, as beets has no knowledge of composers from MB. There's a subtle, but IMHO important, difference between the two approaches.

@sampsyo
Copy link
Member

sampsyo commented Jan 25, 2015

Agreed: related but slightly different. They should perhaps be solved both at once.

@jackwilsdon jackwilsdon added the feature features we would like to implement label Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

4 participants