Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update getrandom #2341

Open
oligamiq opened this issue Feb 8, 2025 · 5 comments
Open

update getrandom #2341

oligamiq opened this issue Feb 8, 2025 · 5 comments

Comments

@oligamiq
Copy link

oligamiq commented Feb 8, 2025

please update getrandom.

The version of getrandom has been updated. Until now, if you want to compile for wasm,

getrandom = { version = "0.2", features = ["std", "js"] }
getrandom = { version = "0.3.1", features = ["std", "wasm_js"] }

I had written code like this, but it causes problems because the version of getrandom on which this library depends is out of date.

Related issues, etc.
#2218
#2130
#2187

https://rust-random.github.io/book/update-0.9.html
https://github.com/rust-random/rand/blob/master/CHANGELOG.md

@briansmith
Copy link
Owner

It will be a while before I can review the changes between the last time I looked at getrandom and the getrandom 0.3 release. Don't hold your breath.

@oligamiq
Copy link
Author

oligamiq commented Feb 8, 2025

https://github.com/rust-random/getrandom/blob/master/CHANGELOG.md

The changes that may be relevant are
・Rename getrandom and getrandom_uninit functions to fill and fill_uninit respectively
・js features to wasm_js

@oligamiq
Copy link
Author

oligamiq commented Feb 8, 2025

#2342

@briansmith
Copy link
Owner

Thanks. AFAICT getrandom 0.3 changes the way configuration is done in a way that is difficult for ring to adjust to, or at least I am not sure how to adjust ring to use the new configuration mechanism.

Plus, I review every commit in getrandom before I upgrade to a new version. At one point last year I was reviewing getrandom commits in real time, but I haven't reviewed them for a while. So I have about a year of getrandom commits to review 1-by-1 before I can do the update.

@oligamiq
Copy link
Author

oligamiq commented Feb 9, 2025

Is it for security?
Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants