Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 endpoints don't template in helm correctly #15

Closed
grrywlsn opened this issue Jul 15, 2022 · 1 comment · Fixed by #14
Closed

V1 endpoints don't template in helm correctly #15

grrywlsn opened this issue Jul 15, 2022 · 1 comment · Fixed by #14

Comments

@grrywlsn
Copy link

Helm (via Flux's HelmRelease CRD) wasn't able to parse the boolean values for the V1 environment variables. I've swapped to putting them in quotes, which parses fine and allows the helm chart to install.

A sample of the error:

Helm install failed: Deployment in version "v1" cannot be handled as a Deployment: v1.Deployment.Spec: v1.DeploymentSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.Value: ReadString: expects " or n, but found t, error found in #10 byte of ...|,"value":true},{"nam|..., bigger context ...|"env":[{"name":"USE_V1_UPTIME_ENDPOINTS","value":true},{"name":"USERNAME","valueFrom":{"secretKeyRef|...

I've raised #14 with a fix that I've tested, and which resolved this issue. Thanks for the great project!

@chelnak chelnak linked a pull request Jul 17, 2022 that will close this issue
@chelnak
Copy link
Owner

chelnak commented Jul 17, 2022

Thanks so much for submitting this & a fix!

@chelnak chelnak closed this as completed Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants