Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Edit on Github" button in documentation yields a 404 error. #407

Closed
sobotka opened this issue Apr 28, 2018 · 4 comments
Closed

"Edit on Github" button in documentation yields a 404 error. #407

sobotka opened this issue Apr 28, 2018 · 4 comments
Labels
Defect Documentation Minor

Comments

@sobotka
Copy link
Contributor

sobotka commented Apr 28, 2018

http://colour.readthedocs.io/en/develop/_modules/colour/models/jzazbz.html

Hit "Edit on Github" 404s.
@KelSolaar KelSolaar changed the title Documents "Edit on Github" 404s "Edit on Github" button in documentation yields a 404 error. Apr 29, 2018
@KelSolaar
Copy link
Member

@sobotka : Thanks, I don't think we have ever written the _modules RST files containing the code anywhere, seems like this button should not exist when looking at the source code from the documentation. Will probably look on how to disable it.

@KelSolaar
Copy link
Member

KelSolaar commented Apr 29, 2018 •
edited
Loading

html_show_sourcelink = False set in the conf.py file will remove the button although I guess we want to keep it for actual and maintained documentation files.

@KelSolaar
Copy link
Member

More information: sphinx-doc/sphinx#2386

@KelSolaar
Copy link
Member

KelSolaar commented Apr 7, 2019 •
edited
Loading

I think this one was addressed, I cannot see the Edit on Github button anymore on the aforementioned page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Defect Documentation Minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobotka @KelSolaar