-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Type Validation parameter for Pipeline Connections #8875
Open
sjrl
wants to merge
31
commits into
main
Choose a base branch
from
refactor-typing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13455277332Details
💛 - Coveralls |
I have marked the failing HF API test -depending on HF API instability- as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Document
#8524 by allowing the user to set thetype_validation
toFalse
for connecting those components togetherProposed Changes
This PR introduces a new
connection_type_validation
parameter for type compatibility checks and adds_types_are_compatible
, and_strict_types_are_compatible
functions to support it. Theconnection_type_validation
parameter allows users to configure whether type validation is performed or not. IfTrue
then type validation is performed ifFalse
then all connections are allowed.Additionally, I allow this option to be set at the pipeline level or at the individual connection level. I've updated the to_dict and from_dict methods of the pipeline to reflect this.
How did you test it?
Notes for the reviewer
@mpangrazzi I'd appreciate your thoughts on the name of the variable and whether you think it makes sense to have the option available at both the pipeline level and the connection level or if it would make sense to only have it present in one spot.
Checklist
!
if this includes breaking changes.