Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate fingerprinting test data in Blazor.BuildPublishTests.DefaultTemplate_CheckFingerprinting #112814

Open
maraf opened this issue Feb 22, 2025 · 1 comment · May be fixed by #112859
Open

Evaluate fingerprinting test data in Blazor.BuildPublishTests.DefaultTemplate_CheckFingerprinting #112814

maraf opened this issue Feb 22, 2025 · 1 comment · May be fixed by #112859
Assignees
@ilonatommy
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono in-pr There is an active PR which will close this issue when it is merged needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-browser Browser variant of arch-wasm test-enhancement Improvements of test source code
Milestone
10.0.0

Comments

@maraf
Copy link
Member

maraf commented Feb 22, 2025

The BlazorWasmSDK was previously enforcing WasmFingerprintDotnetJs=false. That changed in dotnet/sdk#46233 and now it is driven by WasmSDK and WriteImportMapToHtml property.

We should evaluate whether the Blazor.BuildPublishTests.DefaultTemplate_CheckFingerprinting is still meaningful
@maraf maraf added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm test-enhancement Improvements of test source code labels Feb 22, 2025
@maraf maraf added this to the 10.0.0 milestone Feb 22, 2025
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 22, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@maraf maraf mentioned this issue Feb 22, 2025
Open
@ilonatommy ilonatommy linked a pull request Feb 24, 2025 that will close this issue
Open
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-VM-meta-mono in-pr There is an active PR which will close this issue when it is merged needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-browser Browser variant of arch-wasm test-enhancement Improvements of test source code
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Fix information flow about fingerprinting dotnet files in WBT ilonatommy/runtime
3 participants
@jeffschwMSFT @maraf @ilonatommy