Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[outerloop] Assertion failed '(*use)->WasMorphed()' in R2R legs #112867

Open
steveisok opened this issue Feb 24, 2025 · 7 comments · May be fixed by #112888
Open

[outerloop] Assertion failed '(*use)->WasMorphed()' in R2R legs #112867

steveisok opened this issue Feb 24, 2025 · 7 comments · May be fixed by #112888
Assignees
@AndyAyersMS
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs in-pr There is an active PR which will close this issue when it is merged
Milestone
10.0.0

Comments

@steveisok
Copy link
Member

These failures started popping up in the R2R outerloop for all platforms.

D:\a\_work\1\s\src\coreclr\jit\morph.cpp:13046
Assertion failed '(*use)->WasMorphed()' in 'InvalidCSharp.GenericByRefLike_Over`1[System.__Canon]:AllocArrayOfT():ubyte:this' during 'Morph - Global' (IL size 10; hash 0x98ef367a; FullOpts)

D:\a\_work\1\s\src\coreclr\jit\morph.cpp:13046
Assertion failed '(*use)->WasMorphed()' in 'Exec:AllocArray[System.__Canon]():ubyte' during 'Morph - Global' (IL size 10; hash 0x04bcbd54; FullOpts)

https://dev.azure.com/dnceng-public/public/_build/results?buildId=959769&view=ms.vss-test-web.build-test-results-tab&runId=25550398&resultId=123253&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab
@steveisok
Copy link
Member Author

/cc @AndyAyersMS

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 24, 2025
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Feb 24, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid amanasifkhalid added blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs and removed untriaged New issue has not been triaged by the area owner labels Feb 24, 2025
@amanasifkhalid amanasifkhalid added this to the 10.0.0 milestone Feb 24, 2025
@amanasifkhalid
Copy link
Member

cc @dotnet/jit-contrib

@AndyAyersMS
Copy link
Member

Seems to be from one of these:

f1b8d5a Fold null checks against known non-null values (#109164)
54e55db JIT: Always track the context for late devirt (#112396)
bde9ba9 JIT: array allocation fixes (#112676)
995b6de JIT: Don't use Compiler::compFloatingPointUsed to check if FP kills are needed (#112668)

@amanasifkhalid
Copy link
Member

Seems to be from one of these:

It probably isn't #112668 since that only affects LSRA. #112676 looks unlikely too.

@AndyAyersMS
Copy link
Member

As usual these days, I can't repro locally. Grr.

@AndyAyersMS
Copy link
Member

Looking at the dump it seems like it's #109164 -- it can create an un-morph flagged constant.

Will work up a fix.

AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue Feb 25, 2025
@AndyAyersMS
JIT: fix missing morphed flag
5cab66d 
Fixes dotnet#112867.
@AndyAyersMS AndyAyersMS linked a pull request Feb 25, 2025 that will close this issue
Open
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

JIT: fix missing morphed flag AndyAyersMS/runtime
3 participants
@steveisok @AndyAyersMS @amanasifkhalid