Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the custom sampling loop #1422

Open
rlouf opened this issue Feb 17, 2025 · 0 comments
Open

Remove the custom sampling loop #1422

rlouf opened this issue Feb 17, 2025 · 0 comments
Assignees
Labels
enhancement structured generation Linked to structured generation
Milestone

Comments

@rlouf
Copy link
Member

rlouf commented Feb 17, 2025

We won't need the custom sampling loop once v1.0 is ready. Remove it in a separate PR so we can easily revert the change in the future if we need to.

@rlouf rlouf added enhancement structured generation Linked to structured generation labels Feb 17, 2025
@rlouf rlouf added this to the 1.0 milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement structured generation Linked to structured generation
Projects
None yet
Development

No branches or pull requests

2 participants