Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appender: add support for appending Long, Integer, Short and Boolean #139

Open
maartenbosteels opened this issue Feb 19, 2025 · 1 comment

Comments

@maartenbosteels
Copy link

Currently the DuckDBAppender supports appending objects of type java.lang.String and primitive types like int, short, boolean and long.

When appending to a table that has nullable columns, it would be very convenient to have methods for these wrapper classes:

  • java.lang.Boolean
  • java.lang.Long
  • java.lang.Integer
  • java.lang.Short

Given a class like

    class Person {
        Integer age;
        Long ssn;
    }

Currently, one has to write

    public void append(DuckDBAppender appender, Person person) throws SQLException {         
        appender.beginRow();
        if (person.age != null) {
            appender.append(person.age);
        } else {
            appender.append((String) null);
        }
        if (person.ssn != null) {
            appender.append(person.ssn);
        } else {
            appender.append((String) null);
        }
        appender.endRow();
    }

While it could become:

    public void append(DuckDBAppender appender, Person person) throws SQLException {
        appender.beginRow();
        appender.append(person.age);
        appender.append(person.ssn);
        appender.endRow();
    }

if DuckDBAppender would have support for the wrapper classes and do the null checking.

@maartenbosteels
Copy link
Author

#140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant