Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember Inspector has errored with ember-feature-flags #814

Closed
vladucu opened this issue May 31, 2018 · 2 comments · Fixed by #859
Closed

Ember Inspector has errored with ember-feature-flags #814

vladucu opened this issue May 31, 2018 · 2 comments · Fixed by #859
Labels

Comments

@vladucu
Copy link
Contributor

vladucu commented May 31, 2018

Hi,

Not sure if this is the right place, but thought of reporting this

Ember Inspector: 3.1.1
Ember: 3.1.2
Ember CLI: 3.1.4
Ember Feature Flags: 5.0.0

In our app, we inject the features service in routes, components, etc using an initializer. Trying to click on any component, route, etc triggers the following in console and fails to open the Inspector tab
screen shot 2018-05-31 at 2 12 00 pm

NOTE:

  • if we remove the initializer and inject the features service manually the tab works when clicking on components/routes... but still in Ember Inspector clicking on Container in the sidebar then on the features service same thing still happens
@RobbieTheWagner
Copy link
Member

@vladucu without doing further debugging, I would blindly guess this is an issue with:

options.isService = hash[prop].type === 'service';

Would you be interested in potentially trying to determine if that is where the issue is and if so adding a fix there? If that is where the issue lies, potentially we could do a check for if the object is a proxy somehow, and use .get('type') otherwise just grab .type?

@vladucu
Copy link
Contributor Author

vladucu commented May 31, 2018

@rwwagner90 sure, will try to confirm if this is the cause and maybe a fix...thx for pointing me in the right direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants