Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve color picker #230

Closed
bel8z opened this issue Mar 15, 2021 · 1 comment
Closed

Improve color picker #230

bel8z opened this issue Mar 15, 2021 · 1 comment

Comments

@bel8z
Copy link

bel8z commented Mar 15, 2021

In the color picker widget, the "Hue" slider is affected by the currently selected "Saturation" and "Value": this makes impossible to see the hue scale at low saturation and/or value.
This is a minor usability issue, but one that can make users frustrated since every other color picker keep the hue scale always visible.

The fix seems too small to be worth a pull request: in color_picker.rs, color_slider_1d(ui, h, |h| HsvaGamma { h, ..opaque }.into()); becomes color_slider_1d(ui, h, |h| HsvaGamma { h, s: 1.0, v:1.0, ..opaque }.into());.

Let me know what do you think about it, and keep up with the great job!

@emilk emilk closed this as completed in c1d5bda Mar 21, 2021
@emilk
Copy link
Owner

emilk commented Mar 21, 2021

Yeah, makes sense! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants