Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static setting for global params #180

Open
mateusfigmelo opened this issue Feb 24, 2025 · 0 comments
Open

Static setting for global params #180

mateusfigmelo opened this issue Feb 24, 2025 · 0 comments

Comments

@mateusfigmelo
Copy link

You can relevant code here

def input_parser(plan, input_args):
    sanity_check.sanity_check(plan, input_args)
    results = parse_network_params(plan, input_args)

    results["global_log_level"] = "info"
    results["global_node_selectors"] = {}
    results["global_tolerations"] = []
    results["persistent"] = False

    return struct(
    ...

Current implementation applied default setting for global parameters after parsing network params.
So even after applying global params in network_params.yaml, we cannot get a fair result for these params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant