Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LNK2019 (VirtualAllocFromApp) #101

Closed
Guekka opened this issue Mar 8, 2021 · 1 comment
Closed

LNK2019 (VirtualAllocFromApp) #101

Guekka opened this issue Mar 8, 2021 · 1 comment

Comments

@Guekka
Copy link
Contributor

Guekka commented Mar 8, 2021

Looking at older PRs, it was introduced by #80. I don't know why, but replacing in virtual_memory.cpp :
#if (_MSC_VER <= 1900)
with
#if (_MSC_VER <= 1900) || WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP)
fixes it. Not sure if it is a real fix.
@foonathan
Copy link
Owner

The fix does make sense. The PR originally checked only for the partition, but that didn't work for older MSVCs, so it was replaced by the version check. Doing both would have been the proper solution.

Can you do a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@foonathan @Guekka