Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env setting for imageCacheDirectory #1067

Closed
Jotschi opened this issue Apr 29, 2020 · 4 comments
Closed

Add env setting for imageCacheDirectory #1067

Jotschi opened this issue Apr 29, 2020 · 4 comments

Comments

@Jotschi
Copy link
Contributor

Jotschi commented Apr 29, 2020

The imageCacheDirectory in ImageManipulatorOptions can currently not be configured. We should add an Env to allow this.

@karowin
Copy link
Contributor

karowin commented May 8, 2020

@Jotschi I was going through this issue, and our understanding is that we have to add the environment variable to the class ImageManipulatorOptions , so that the configuration present in the mesh.yml gets effective. Could you please confirm this.

@Jotschi
Copy link
Contributor Author

Jotschi commented May 8, 2020

@karowin Yes. But I think I may have already fixed this. Let me check.

@Jotschi
Copy link
Contributor Author

Jotschi commented May 8, 2020

@karowin I checked. I did not yet fix it.

https://github.com/gentics/mesh/blob/hotfix-1.4.x/api/src/main/java/com/gentics/mesh/etc/config/ImageManipulatorOptions.java#L27

The field would require the EnvironmentVariable annotation. Additionally I suggest to also add a testcase in the options loader test class:

https://github.com/gentics/mesh/blob/hotfix-1.4.x/common/src/test/java/com/gentics/mesh/OptionsLoaderTest.java#L46

@karowin
Copy link
Contributor

karowin commented May 8, 2020

@Jotschi thanks for the clarification.

@Jotschi Jotschi closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants