Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warm pool launch configuration #4421

Open
AayushbajajCAW opened this issue Feb 13, 2025 · 1 comment
Open

Warm pool launch configuration #4421

AayushbajajCAW opened this issue Feb 13, 2025 · 1 comment

Comments

@AayushbajajCAW
Copy link

Warm pool launch configuration

I had a suggestion for adding an autoscaling group for a warm pool to this terraform configuration. This would reduce the boot up time of an ASG without significantly increasing cost. I’m open to feedback and questions on my approach.

Here is how I propose an implementation:
Instead of the lambda calling the EC2 API to create a runner, we introduce an ASG and the lambda calls the ASG for capacity.

@npalm
Copy link
Member

npalm commented Feb 20, 2025

I think there are two reasons why I have implemented the pool back in the days with Lambda

  1. Simply re-use most of the runner scale up logic, avoid more code / more maintenace, as well complexity
  2. The create runners a JIT token needs to be created. This is stored with the instance id. In case moving to an ASG, the scaling group creates the instances. Question is how to distribute the JIT token safely to the instance.

Any thoughts on how to solve those challenges?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants