-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect values when making column nullable #691
Comments
@kwburgess can you please clarify, #681 was about the |
@kwburgess #692 tests your scenario and passes. Can you please examine? |
Thank you @shlomi-noach ch for the rapid replies and careful attention. I've determined your tests can't run on Mac OS, which is fine. eventually, I got by on a Centos.
Wondering if you had any extended setup instructions? |
With a little more investigation (couldn't find this in the docs), I'm guessing I have to run so I attempted to do so: ./script/cibuild-gh-ost-replica-tests outputI initially ran as my own user, and it failed even earlier.
I can see that the test you wrote passed, but how might I inspect the table it created to verify your test syntax with the test reproduction steps I gave you above?
is the same as
|
Hi, What you need, and this isn't well documented:
As per your 2nd question, "how might I inspect the table it created to verify your test syntax with the test reproduction steps I gave you above?", you will want to look at the Replica server, into Last,
It is indeed the same. Only thing that changed are the names, but otherwise it's the exact same table definition. |
18446744073709551615 is 2^64-1, which exceeds the max value of a signed BIGINT. @kwburgess, are you getting a WARNING after that insert? |
I'm using
And I cannot insert it into the table following your steps.
I guess that it's not a problem caused by gh-ost. |
Confirmed: #684 (related issue: #681 ) did not fix this problem.
Using gh-ost to make a column to be nullable results in incorrect values for the column.
Initial guess is an overflow issue of some sort.
Reproduction steps:
./gh-ost --host=localhost --user=test --password=test --database=test \ --allow-on-master --alter="CHANGE test_id test_id bigint(20);" \ --table=ghost_overflow_test --execute
id went from 18446744073709551615 -> 9223372036854775807
Versions:
$ mysql --version mysql Ver 14.14 Distrib 5.7.11, for Linux (x86_64) using EditLine wrapper $ go version go version go1.9.2 linux/amd64
tested on gh-ost master branch and test-decimal branch
The text was updated successfully, but these errors were encountered: